On Thu, 2013-02-07 at 10:41 +0100, Stefan Huber wrote:
> >> - /* Try to find matching input ports for this output port */
> >> + for (oc = 0; oc < n_oc; oc++) {
> >> + pa_bool_t oc_connected = FALSE;
> >While you're rewriting this function, you could also change every
> >pa_bool_t to bool, every TRUE to true and every FALSE to false.
>
> Hm. Consequently, the helper functions like on_left, front_rear_side,
> etc. should be adopted, too. So if we make changes for a few functions
> we should do that for the entire file. Shouldn't this be better done in
> a separate commit?
on_left etc. don't necessarily need to be adapted. pa_bool_t and bool
are compatible (except maybe not if you're handling a pointer to the
boolean, I'm not sure about that case, but that's not relevant here).
I'd be happy with either of these two alternatives: only update
calc_map_table() without a separate patch, or update resampler.c in its
entirety with a separate patch.
Ack for the changes between v1 and v2.
--
Tanu
