From: Peter Meerwald <p.meerwald@xxxxxxxxxxxxxxxxxx> https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8477&defectInstanceId=3693&mergedDefectId=591269 Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net> --- src/pulsecore/core-util.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c index 2efa280..0d9e354 100644 --- a/src/pulsecore/core-util.c +++ b/src/pulsecore/core-util.c @@ -326,16 +326,20 @@ again: goto fail; } - if (!update_perms) + if (!update_perms) { + pa_assert_se(pa_close(fd) >= 0); return 0; + } #ifdef HAVE_FCHOWN if (uid == (uid_t) -1) uid = getuid(); if (gid == (gid_t) -1) gid = getgid(); - if (fchown(fd, uid, gid) < 0) + if (fchown(fd, uid, gid) < 0) { + pa_assert_se(pa_close(fd) >= 0); goto fail; + } #endif #ifdef HAVE_FCHMOD -- 1.7.9.5
