On Mon, Apr 29, 2013 at 11:01 AM, Tanu Kaskinen <tanu.kaskinen at intel.com> wrote:
> On Fri, 2013-04-26 at 12:30 -0300, jprvita at gmail.com wrote:
>> From: Jo?o Paulo Rechi Vita <jprvita at openbossa.org>
>>
>> ---
>>
>> As already discussed with Tanuk and Mikel, this series should be applied to the
>> master branch.
>
> I don't remember there being any talk about pushing this series to the
> master branch. I will use next, unless you have a good reason why this
> needs to be in 4.0.
>
That was my understanding when we talked about breaking the card
properties API. This series basically removes bluez.name and adds
bluez.alias instead. But either way is fine to me.
>>
>> src/modules/bluetooth/module-bluetooth-device.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c
>> index c877df2..8695c80 100644
>> --- a/src/modules/bluetooth/module-bluetooth-device.c
>> +++ b/src/modules/bluetooth/module-bluetooth-device.c
>> @@ -2243,6 +2243,7 @@ static int add_card(struct userdata *u) {
>> pa_proplist_sets(data.proplist, "bluez.path", device->path);
>> pa_proplist_setf(data.proplist, "bluez.class", "0x%06x", (unsigned) device->class);
>> pa_proplist_sets(data.proplist, "bluez.name", device->name);
>> + pa_proplist_sets(data.proplist, "bluez.alias", device->alias);
>
> device->alias is not guaranteed to be non-NULL, so this code can crash.
> If the Alias property is non-optional in Bluez, bluetooth-util should
> ensure that it is indeed always set.
>
> --
> Tanu
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
--
Jo?o Paulo Rechi Vita
http://about.me/jprvita
