On Mon, 2012-08-20 at 23:50 +0200, Thomas Martitz wrote: > I've been tryng to run pulseaudio (including utils) on windows. This > series is the first to contribute fixes to achieve this. > > One issue I came across is the assertion failue (!e->dead) in pacat. This > is fixed by the third patch. Uncovered by this and fixed by patch 2 is that > stdio needs to be switched to binary mode in order to pipe data through it. > Patch 1 works around massive build warnings on mingw32, but it's not mission > critical (note: I don't know why the patch order of 1-3 is different to the > first set). Another issue was pa_read() failure in flush(), which wasn't > actually failure, but rather not handling non-blocking sockets. Actually, > I'm not sure if the fix is correct (perhaps because pa_read() should not wait > for non-block sockets or the fix is windows-only) but it functions as a work- > around. The last 2 patches are more or less minor and speak for themselves. > > Please review and comment on my patches, especually patch#4. This is my > first contribution to PA, but surely not the last one so I would like to > get things right. > Sorry about an awful wait for your first patches. I've commented on a few of them, and I'm pushing out the rest now. There are minor cosmetic changes to some of them (and I've not bothered rewrapping them at 80 columns, but that would be nice). Thanks for the work! Regards, Arun
