[PATCH PA1.1 1/2] alsa-sink: add missing header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Eero,


Am Donnerstag, den 31.05.2012, 09:42 +0300 schrieb eero.nurkkala at offcode.fi:
> Quoting Paul Menzel:
> >>  #include <stdio.h>
> >> +#include <signal.h>
> >
> > Is sorting headers in these blocks useful?

> I missed the point about sorting - would you rather want the signal.h
> on top of stdio.h maybe?

yes, that is what I meant. Sorry, for not being clear.

> >>  #include <asoundlib.h>
> >
> > It would be great if you could resend as [PATCH v2]. You could also make
> > the commit summary more informational.
> >
> >     alsa-sink: add missing header `signal.h`
> 
> Sure,

Great!


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20120531/4d3d63c8/attachment.pgp>


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux