On Thu, 2012-05-24 at 12:27 +0200, David Henningsson wrote: > On 05/22/2012 06:06 PM, poljar wrote: > > A new function was added to module.c to handle unload requests by name. > > The native protocol was extended and a new opcode was introduced, and > > finally pactl was extended to make use of the new functionality. > > I gave them a quick read through and they all looked good to me! We spoke about this on IRC and the conclusion was that the only current users of this code are likely to be pactl/pacmd. It seems a bit overkill to extend the protocol without any other users that we can foresee. Coupling that with the fact that we're adding policy in addition to mechanism with this API (for multiple modules with the same name), this patch set stands punted. Hopefully it was still good learning experience for poljar about API stability and extending the protocol. Cheers, Arun
