I missed one thing: On Fri, 2012-06-08 at 17:20 +0530, Arun Raghavan wrote: [...] > > +/* UCM modifier action direction */ > > +enum { > > + PA_ALSA_UCM_DIRECT_NONE = 0, > > + PA_ALSA_UCM_DIRECT_SINK, > > + PA_ALSA_UCM_DIRECT_SOURCE > > +}; I'd prefer DIRECTION to DIRECT for clarity. -- Arun