On 06/28/2012 06:25 PM, Tanu Kaskinen wrote: > On Thu, 2012-06-28 at 16:27 +0200, David Henningsson wrote: >> Several laptops have speaker ports, and/or internal mic ports, but we have >> no way of detecting that. So we make the port(s) always show up for these >> devices. >> >> BugLink: https://bugs.launchpad.net/bugs/946232 >> Signed-off-by: David Henningsson <david.henningsson at canonical.com> > >> +; For devices where a 'Internal Mic' or 'Internal Mic Boost' element exists >> +; 'Int Mic' and 'Int Mic Boost' are for compatibility with kernels < 2.6.38 >> +; >> +; See analog-output.conf.common for an explanation on the directives > > Not really problem with this specific patch, but anyway, I saw > analog-output.conf.common, and I didn't find any explanation for the > jack state directives (they are completely new to me). > analog-output.conf.common needs updating. > > Otherwise looks good to me. The mostly copy-pasted profile-set files > aren't very cool, though, but I don't have any good solution for it > right now. Btw, the conf parser supports include files, so if we can verify that overriding something works correctly, we could just override the relevant section - or line - in the special .conf and then include default.conf? -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
