[PATCH 1/5] module-coreaudio-detect: fix pa__done()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2011-03-20 at 18:39 +0100, Daniel Mack wrote:
>  void pa__done(pa_module *m) {
> -    struct userdata *u;
> +    struct userdata *u = m->userdata;
>      struct ca_device *dev = u->devices;
>      AudioObjectPropertyAddress property_address;
>  
> -    pa_assert(m);
> -    pa_assert_se(u = m->userdata);
> -
>      property_address.mSelector = kAudioHardwarePropertyDevices;
>      property_address.mScope = kAudioObjectPropertyScopeGlobal;
>      property_address.mElement = kAudioObjectPropertyElementMaster;

I think the old assertions were good. I'd rather initialize dev after
the assertions.

-- 
Tanu




[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux