On Thu, Mar 03, 2011 at 02:56:27PM +0000, Colin Guthrie wrote: > Just a quick note to say I've now applied this patch to pavucontrol. > Many thanks :) > > I made the commit with your details as I only made a tiny modification > (dropped the unneeded change to src/Makefile.am and named the glade file > to drop the 2 you added). > > I added a couple post conversion fixes too. > Thanks, though a minor clarification: - the rename was simply for my testing, I haven't removed it from the patch only by mistake - CXXFLAGS -> CPPFLAGS, while technically unneeded, are stylewise more correct, just see automake's info page - even though pkg-config names them CFLAGS, nearly every time (that is: for nearly every package (at least the ones, I came across), that uses pkg-config) they're just CPPFLAGS
