On Tue, 2011-03-01 at 21:38 +0200, Tanu Kaskinen wrote:
> On Wed, 2011-03-02 at 00:43 +0530, Arun Raghavan wrote:
> > This completes the client-side changes to the protocol extension
>
> Thanks for fixing this!
>
> I forgot also incrementing PA_PROTOCOL_VERSION in my patch, so you
> should fix that too.
Missed that because of my local changes.
> > introduced by commit 99ddca89cdca9b0b92ab9870764f9211e6a82e31
> > ---
> > src/pulse/introspect.c | 8 ++++++--
> > 1 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/pulse/introspect.c b/src/pulse/introspect.c
> > index 2a81788..575ca8d 100644
> > --- a/src/pulse/introspect.c
> > +++ b/src/pulse/introspect.c
> > @@ -996,7 +996,7 @@ static void context_get_sink_input_info_callback(pa_pdispatch *pd, uint32_t comm
> >
> > while (!pa_tagstruct_eof(t)) {
> > pa_sink_input_info i;
> > - pa_bool_t mute = FALSE, corked = FALSE;
> > + pa_bool_t mute = FALSE, corked = FALSE, has_volume, read_only_volume;
>
> The new variables should be initialized - if the server uses a protocol
> version less than 20, you assign undefined values to i.has_volume and
> i.read_only_volume.
D'oh! Agreed and sent fixed patch.
-- Arun
