'Twas brillig, and Maarten Bosmans at 11/01/11 10:51 did gyre and gimble: > I'll prepare a new patch series with all your points adressed. Sweet. Feel free to supply a remote from which I can pull if it's easier (doesn't matter much to me). I'm not 100% sure of setenv vs putenv but both appear to be as thread safe as the other (the only reason I can think of to favour one over the other). It dates back a while (045c1d60: Glitch free merge to trunk - in svn days), but putenv() was used prior to that and introduced in 9c87a65ce91c38b60c19ae108a51a2e8ce46a85c. Doesn't look like it was used over setenv() for any real reason, so I guess that should be fine. Thanks for looking at this :) Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]