Hi Colin: Thanks a lot for making this better :-) On 01/03/2011 05:49 PM, Colin Guthrie wrote: > 'Twas brillig, and Colin Guthrie at 30/12/10 12:09 did gyre and gimble: >> 'Twas brillig, and Cai Yuanqing at 30/12/10 07:18 did gyre and gimble: >>> Hi Colin: >>> >>> Could you review this patch for a while,and give me some comments :-) >> Hmm, thought I'd replied to this already, but I guess I just looked... >> >> It seems fine. I'll include it when I next do some merging after the new >> year. Right now I'm off to lock myself in a cabin in the highlands with >> a bunch of mates and a few bottles of good whisky! Sl?inte Mhath! > Head almost back to normal now! > > Had a closer review and found a small bug (flags for the sink input were > overwritten further down the code). I've rejigged things a little and > made things a bit more symmetrical (although somewhat redundant) to make > things a little clearer. > > Cheers > > Col > -- B.R Cai Yuanqing