On Sun, 2011-02-27 at 16:30 +0200, Tanu Kaskinen wrote: > On Sun, 2011-02-27 at 14:15 +0000, Colin Guthrie wrote: > > diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c > > index d713be1..4da36f3 100644 > > --- a/src/pulsecore/sink.c > > +++ b/src/pulsecore/sink.c > > @@ -1705,8 +1705,6 @@ void pa_sink_set_volume( > > pa_cvolume_reset(&root_sink->soft_volume, > > root_sink->sample_spec.channels); > > if (!(root_sink->flags & PA_SINK_SYNC_VOLUME)) > > root_sink->set_volume(root_sink); > > - else > > - send_msg = TRUE; > > > > } else > > /* If we have no function set_volume(), then the soft volume > > > > > > It's in my tree now, but perhaps more tweakage needed? > > That should be ok. Or did you have some specific tweakage in mind? Now it occurred to me that one thing needs tweaking still: the commit message. It's PA_SINK_MESSAGE_SET_SHARED_VOLUME instead of _VOLUME_SYNCED that the commit message should mention when applied on top of the volume sharing patch. -- Tanu
