RFC: Adding hooks for port+profile changes (possibly UCM related)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-02-25 at 11:29 +0000, Colin Guthrie wrote:
> 'Twas brillig, and Colin Guthrie at 25/02/11 11:23 did gyre and gimble:
> > diff --git a/src/pulsecore/card.c b/src/pulsecore/card.c
> > index 2f0a3af..1758f48 100644
> > --- a/src/pulsecore/card.c
> > +++ b/src/pulsecore/card.c
> > @@ -214,6 +214,7 @@ int pa_card_set_profile(pa_card *c, const char
> > *name, pa_bool_t save) {
> >      pa_card_profile *profile;
> >      int r;
> >      pa_assert(c);
> > +    pa_assert(c->core);
> > 
> >      if (!c->set_profile) {
> >          pa_log_debug("set_profile() operation not implemented for card
> > %u \"%s\"", c->index, c->name);
> 
> Oops, this assert is not needed (doesn't hurt tho') I didn't mean to
> commit it. Removed from my tree now.
> 
> But the "is this sensible"? question still remains :)

Yes, I think it's very sensible. Ship it :)

-- 
Tanu




[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux