On Fri, 2011-02-25 at 11:14 +0000, Colin Guthrie wrote: > Forgive my ignorance of how the virtual-sink.c works (I've really not > looked) but my (perhaps incorrect) understanding was that it is > basically a code template rather than a real sink. > > Is this just a wrong grasp of the situation? Well, it is a template, but it's also fully functional. The functionality is just very limited :) > If it's not wrong, should the changes there to modargs etc. be migrated > to the modules which have been spawned from virtual sink? I believe there aren't actually any modules yet spawned from the virtual sink. But your point is still valid - if you think the changes that I made for module-virtual-sink are useful for other filter sinks, feel free to modify those other sinks too. I don't think that at least the force_flat_volume option is generally of much use, though - I added it to module-virtual-sink just so that I could easily have both flat volume and non-flat volume sinks for testing stream moving between the two sink types. I could have copied module-virtual-sink into a new module, maybe called module-filter-test-sink, in the name of keeping the template module cleaner, but I thought that would be too much redundancy just for some simple debug options in module-virtual-sink. -- Tanu
