[PATCH] dbusiface-stream: Send the Device property in the GetAll handler.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/2/22 Tanu Kaskinen <tanu.kaskinen at digia.com>:
> ---
> ?src/modules/dbus/iface-stream.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/modules/dbus/iface-stream.c b/src/modules/dbus/iface-stream.c
> index 681790b..cfba5ad 100644
> --- a/src/modules/dbus/iface-stream.c
> +++ b/src/modules/dbus/iface-stream.c
> @@ -555,6 +555,7 @@ static void handle_get_all(DBusConnection *conn, DBusMessage *msg, void *userdat
> ? ? if (client)
> ? ? ? ? pa_dbus_append_basic_variant_dict_entry(&dict_iter, property_handlers[PROPERTY_HANDLER_CLIENT].property_name, DBUS_TYPE_OBJECT_PATH, &client_path);
>
> + ? ?pa_dbus_append_basic_variant_dict_entry(&dict_iter, property_handlers[PROPERTY_HANDLER_DEVICE].property_name, DBUS_TYPE_OBJECT_PATH, &device);
> ? ? pa_dbus_append_basic_variant_dict_entry(&dict_iter, property_handlers[PROPERTY_HANDLER_SAMPLE_FORMAT].property_name, DBUS_TYPE_UINT32, &sample_format);
> ? ? pa_dbus_append_basic_variant_dict_entry(&dict_iter, property_handlers[PROPERTY_HANDLER_SAMPLE_RATE].property_name, DBUS_TYPE_UINT32, &s->sample_rate);
> ? ? pa_dbus_append_basic_array_variant_dict_entry(&dict_iter, property_handlers[PROPERTY_HANDLER_CHANNELS].property_name, DBUS_TYPE_UINT32, channels, channel_map->channels);
> --

Ah, what a coincidence!
Just an hour ago, I put the pulse sources throught the clang static
code analyzer. Not much errors, mostly a couple of false positives.
The unused device variable in handle_get_all was about the only real
problem (together with an unused buffer_size variable in
alsa_source/sink) and now you fixed it.

Maarten



[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux