On Wed, 2011-12-21 at 20:39 +0530, Arun Raghavan wrote:
> IMO EsounD is really quite irrelevant on most modern systems today, and more
> so for embedded systems.
>
> Any objections to making it optional?
I think I've read somewhere that the main motivation for Pulseaudio was
that EsounD sucked, and a drop-in replacement was needed. Since being
EsounD compatible is the main purpose, having EsounD compatibility can't
be optional!
Just kidding. My only complaint is that all other dependencies use
format HAVE_SOMETHING instead of WANT_SOMETHING, and for example Solaris
support has this configure.ac snippet (other dependencies seem to be
similar):
AC_ARG_ENABLE([solaris],
AS_HELP_STRING([--disable-solaris],[Disable optional Solaris audio
support]))
AS_IF([test "x$enable_solaris" != "xno"],
[AC_CHECK_HEADERS([sys/audio.h], HAVE_SOLARIS=1, HAVE_SOLARIS=0)],
HAVE_SOLARIS=0)
AS_IF([test "x$enable_solaris" = "xyes" && test "x$HAVE_SOLARIS" =
"x0"],
[AC_MSG_ERROR([*** Solaris audio support not found])])
AM_CONDITIONAL([HAVE_SOLARIS], [test "x$HAVE_SOLARIS" = x1])
AS_IF([test "x$HAVE_SOLARIS" = "x1"], AC_DEFINE([HAVE_SOLARIS], 1, [Have
Solaris audio?]))
I know very little about autoconf - why is it sufficient to have only
this, much shorter snippet, for EsounD?
AC_ARG_ENABLE([esound],
AS_HELP_STRING([--disable-esound],[Disable optional EsounD
support]))
AM_CONDITIONAL([WANT_ESOUND], [test "x$enable_esound" != "xno"])
--
Tanu
