> Your patch contains the following :
> PA_ECHO_CANCELLER_SPEEX = 0,
> +#ifdef HAVE_SPEEX
> + PA_ECHO_CANCELLER_SPEEX,
> +#endif
> +#ifdef HAVE_ADRIAN_EC
> PA_ECHO_CANCELLER_ADRIAN,
> This will lead to a bug if Speex is disabled and Adrian
> or WRT is enabled, since ec_table will contain Adrian or WRT at index 0.
yes, the following should work
typedef enum {
PA_ECHO_CANCELLER_INVALID = -1,
+#ifdef HAVE_SPEEX
+ PA_ECHO_CANCELLER_SPEEX,
+#endif
+#ifdef HAVE_ADRIAN_EC
PA_ECHO_CANCELLER_ADRIAN,
+#endif
#ifdef HAVE_WEBRTC
PA_ECHO_CANCELLER_WEBRTC,
#endif
> And also, you'll say I'm picky but when ./configure finishes,
> it displays a summary with a lot of yes and no. The yes or
> no corresponding to Adrian's is not vertically aligned with the
> others.
yes, the following would work
+ Enable Adrian echo canceller: ${ENABLE_ADRIAN_EC}
I will put up a new patch series also incorporating Arun's comments
thanks, p.
--
Peter Meerwald
+43-664-2444418 (mobile)
