On Tue, 2011-08-23 at 10:00 +0100, Colin Guthrie wrote:
> Yes, the latest code is better but what I was meaning was something like:
>
> diff --git a/src/utils/pacat.c b/src/utils/pacat.c
> index f687402..2568db5 100644
> --- a/src/utils/pacat.c
> +++ b/src/utils/pacat.c
> @@ -91,6 +91,8 @@ static int32_t latency_msec = 0, process_time_msec = 0;
> static pa_bool_t raw = TRUE;
> static int file_format = -1;
>
> +static int cork_requests = 0;
> +
> /* A shortcut for terminating the application */
> static void quit(int ret) {
> pa_assert(mainloop_api);
> @@ -408,6 +410,15 @@ static void stream_event_callback(pa_stream *s,
> const char *name, pa_proplist *p
>
> t = pa_proplist_to_string_sep(pl, ", ");
> pa_log("Got event '%s', properties '%s'", name, t);
> +
> + if (pa_streq(name, PA_STREAM_EVENT_REQUEST_CORK)) {
> + if (!cork_requests)
> + pa_operation_unref(pa_stream_cork(s, 1, NULL, NULL));
> + cork_requests++;
> + } else if (pa_streq(name, PA_STREAM_EVENT_REQUEST_UNCORK)) {
> + cork_requests--;
> + if (!cork_requests)
> + pa_operation_unref(pa_stream_cork(s, 0, NULL, NULL));
> + }
> +
> pa_xfree(t);
> }
>
>
>
> (not a real patch!)
>
>
> This way the actual operation is only sent at the transition of 0->1 and
> not 1->2 etc. (and the opposite, it will only be sent when doing 1->0
> and not from 2->1).
>
> I think this makes sense, but other opinions are welcomed too.
FWIW, that looks fine to me.
--
Tanu
