On Fri, 2011-08-12 at 09:32 +0300, Arun Raghavan wrote:
> On Mon, 2011-08-08 at 15:46 +0300, Tanu Kaskinen wrote:
> [...]
> > @@ -84,6 +84,11 @@ typedef enum pa_core_hook {
> > PA_CORE_HOOK_SOURCE_PORT_CHANGED,
> > PA_CORE_HOOK_SINK_INPUT_NEW,
> > PA_CORE_HOOK_SINK_INPUT_FIXATE,
> > +
> > + /* Fired from pa_sink_input_put() before doing anything else.
> > + * Call data: pointer to the pa_sink_input object. */
> > + PA_CORE_HOOK_SINK_INPUT_PUT_PRE,
> > +
> > PA_CORE_HOOK_SINK_INPUT_PUT,
>
> My only objection is over the name (I want the bikeshed painted purple
> with yellow polka dots!). PA_CORE_HOOK_SINK_INPUT_PUT_START might be
> clearer. Really not a big deal.
No problem, I like yellow polka dots too :) There's
SINK_INPUT_UNLINK_POST, so PUT_PRE would be a bit more in line with
that, I think, but otherwise I agree that PUT_START is a better name.
--
Tanu
