Hi Col, Pls find attached updated patch, it works fine on my Meego platform. Feel free to let me know if there's any risk. --xingchao 2011/8/11 Colin Guthrie <gmane at colin.guthr.ie>: > 'Twas brillig, and Colin Guthrie at 05/08/11 12:41 did gyre and gimble: >> 'Twas brillig, and xing wang at 05/08/11 05:46 did gyre and gimble: >>> Hi, >>> >>> Does anyone has comment on this patch? >> >> Sorry, I forgot about this one. I had it marked as unread, but it fell >> of the bottom of my unread list. Thanks very much for pinging it up again. >> >> I think it looks good, but I'll go over it with a few people in the next >> few days! It's certainly a problem, so it needs fixed and this patch >> looks like the right fix on first glance. > > OK, so this causes the following assert: > > E: [alsa-sink] sink-input.c: Assertion > 'PA_SINK_INPUT_IS_LINKED(i->thread_info.state)' failed at > ../../src/pulsecore/sink-input.c:1049, function > pa_sink_input_update_max_request(). Aborting. > > > This is done when a stream is in a START_CORKED state I believe (paplay > triggered it). > > Either way this cannot be done yet.... can you come up with a better > patch that doesn't break paplay and friends? > > Col > > > > > > -- > > Colin Guthrie > gmane(at)colin.guthr.ie > http://colin.guthr.ie/ > > Day Job: > Tribalogic Limited [http://www.tribalogic.net/] > Open Source: > Mageia Contributor [http://www.mageia.org/] > PulseAudio Hacker [http://www.pulseaudio.org/] > Trac Hacker [http://trac.edgewall.org/] > > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110812/0b186be6/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-avoid-fake-rewind-in-corked-state.patch Type: text/x-patch Size: 1196 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110812/0b186be6/attachment-0001.bin>
