'Twas brillig, and Paul Menzel at 10/09/10 10:56 did gyre and gimble: > thank you for your patch. Could you please send the patch using the Git > tools (`git format-patch -s -1` (and maybe) `git send-email`). This way > developers do not need to copy paste your commit message from your > messages but just use the tools to get this done automatically. > > I do not know if a Signed-off-by line is required though. No, no need for Signed-off. We're not super strict about this as we're not the kernel :D I'll take a look at the patch shortly. It seems from reading the diff that something isn't quite right, but I never do quite trust reading diffs so will try and take a closer look. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mandriva Linux Contributor [http://www.mandriva.com/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]