2010-09-01 20:06, pl bossart skrev: >>> Probably either one will work, but if we're about to release 0.9.22 >>> (heard something from Lennart yet?), I suggest we go with my version for >>> 0.9.22 as that one is the least invasive (only touches non-tsched >>> devices), and keep Pierre's version in master. >> >> Sounds reasonable. Pierre, what's your take? > > That would mean an additional post-release patch for tsched devices. I > am lazy and would prefer a one-stop fix. I don't care if this is > David's or mine, as long as the solution works for both cases. > The only real difference is the bytes/ms parameter. Although ms are > more intuitive, the bytes makes more sense from a hardware point of > view. If you pass a parameter in ms, there might be cases where the > actual number of bytes is lower than the DMA burst, it'll depend on > what frequency the sink operates at. There are some cases where > alsa-sink works at 8kHz (BT-SCO) or 48kHz (all other cases), a 6x > variability in the rewind behavior is difficult to handle. Fair enough, how about the attached compromise (untested)? If you then would like to turn the define of dma_rewind_margin_bytes into a parameter, that should be fairly simple. -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-ALSA-Fix-calculation-of-rewind-margins.patch Type: text/x-patch Size: 1988 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20100902/1ba1bcc1/attachment.bin>
