'Twas brillig, and Tanu Kaskinen at 15/10/10 11:30 did gyre and gimble: >> I'll offer virtual beer to one >> who can explain why the code still works :). > > In your test case (changing sink input volume) send_msg is TRUE. Thanks > for the virtual beer :) I was just going to say "perhaps send_msg == TRUE in your test case" but i think your explanation goes into a little more depth and is thus more deserving of the virtual hopy goodness :D >>>> + } >>>> + else >>>> + ret = s->set_port(s, port); >>>> + >>>> + if (ret < 0) >>>> return -PA_ERR_NOENTITY; >>> >>> ...ret always being 0 in the case of (s->flags & PA_SINK_SYNC_VOLUME) >>> AFAICT. If this is intended then it is better to do the check of ret >>> inside the else itself, but I suspect you want to get the ret value back >>> after sending the message... >>> >> >> Yep, fixed. (I think I already fixed that, but maybe I just thought I did.) > > You did fix this, but you apparently didn't apply the fix to the > upstream version of the patches - hopefully you didn't forget any other > fixes (I checked, and I believe there isn't anything else missing). I should likely wait for fresh patches then rather than the ones posted just after your reply. Other than this missing fix are you happy Tanu? If you prefer to provide a pull URL that's fine too. I've got a lot of remotes in my clone and it's not really difficult to update them etc. and rebases by others in their remotes don't scare me :D Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
