RFC: Adding "headset" form factor sinks to the "phone" intended role

[gmane@xxxxxxxxxxxxxx (Colin Guthrie)]

Hi,

As reported earlier today by Patrick Ben Koetter[1], his device (a
Logitech Logitech Wireless Headset) is not marked as being appropriate
for phone streams.

IMO, this headset is a good example of what you *would* want to use for
phone calls.

What do you think? should we include the following patch, or is there
situations that make this illogical?

diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
index ff4cc17..3224467 100644
--- a/src/pulsecore/sink.c
+++ b/src/pulsecore/sink.c
@@ -2708,7 +2708,8 @@ pa_bool_t
pa_device_init_intended_roles(pa_proplist *p) {
         return TRUE;

     if ((s = pa_proplist_gets(p, PA_PROP_DEVICE_FORM_FACTOR)))
-        if (pa_streq(s, "handset") || pa_streq(s, "hands-free")) {
+        if (pa_streq(s, "handset") || pa_streq(s, "hands-free")
+            || pa_streq(s, "headset")) {
             pa_proplist_sets(p, PA_PROP_DEVICE_INTENDED_ROLES, "phone");
             return TRUE;
         }

Cheers

Col


1. http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/7607
-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]