'Twas brillig, and pl bossart at 11/11/10 16:37 did gyre and gimble: > Inconsistent use of ALSA. The non-blocking behavior is defined either > with SND_PCM_NONBLOCK when the handle is opened, or later with > snd_pcm_nonblock(), Using the two solutions doesn't make sense. Not > sure why the code was written this way in the first place. Probably a > miss when Lennart modified this file with > 84ade2140ed44bf241eda494d0970390e48b21d3 Actually from a quick git blame, it's clear it's from 1c4ad4b64be168d13a31c8147505b88967be4afb + /* We don't pass SND_PCM_NONBLOCK here, since alsa-lib <= + * 1.0.17a would then ignore the SND_PCM_NO_xxx + * flags. Instead we enable nonblock mode afterwards via + * snd_pcm_nonblock(). Also see + * http://mailman.alsa-project.org/pipermail/alsa-devel/2008-August/010258.html */ But we need alsa-lib >= 1.0.19 these days so I say your fix is valid. Will push shortly. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
