On Thu, 29.04.10 11:14, pl bossart (bossart.nospam at gmail.com) wrote: > This is a patch to fix rewind issues. It has the potential to break > audio in Linux, so I would really appreciate it if others could give > it a try and test on their systems. The new rewind_safeguard should be > tuned to the DMA burst size plus some headroom; I chose a default > value of 256 bytes but some exotic embedded hardware might require a > different setting. On my HDAudio test system, 128 bytes was already > more than enough to prevent audible noises. > Thanks for your feedback. Hmm, I had to think about this a bit, but I do agree now that this is a good thing. In the long run, this should probably be done by ALSA (or at least tuned to some value reported by ALSA), but the patch makes a lot of sense to me, and certainly more sense that the watermark value that we currently stay away from the write index. So, I decided that the code is good and suitable for master and have hence commited it. I don't expect problems with it, but we can still change it later on if there turn out to be problems. Thanks, Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net http://0pointer.net/lennart/ GnuPG 0x1A015CC4
