Hi, Thanks a lot for the quick and complete answer! And I agree with you, I would have preferred xray vision as well :-) Sylvain -----Original Message----- From: pulseaudio-discuss-bounces@xxxxxxxxxxxxxxxx [mailto:pulseaudio-discuss-bounces@xxxxxxxxxxxxxxxx] On Behalf Of Colin Guthrie Sent: Tuesday, June 01, 2010 1:47 PM To: pulseaudio-discuss at mail.0pointer.de Subject: Re: How to contribute Hi Sylvain, 'Twas brillig, and Pichon, SylvainX at 01/06/10 09:26 did gyre and gimble: > I?m new on this mailing list. Welcome aboard! > I?m working at Intel and we will probably have to bring some > contributions to pulseaudio. Excellent :D > I?d like to know the good way to bring contributions to the project. > > I?ve already read the coding style page > (http://www.pulseaudio.org/wiki/CodingStyle) but would like to know if > there is a specific process to follow. Following the coding style is very much recommended.... Lennart (IRC: mezcalero) has special powers to spot // comments in code ..... he really doesn't like them - /* */ all the way :p Personally I'd have preferred to have the super power of invisibility or xray vision, but I guess you can't pick and and choose what radio-active bug bites will do to you.... > Or if it?s just git-cloning the project, create a local branch and push > it when the work is done. Yeah, just clone it and then push it back to a publiccally available git repository somewhere and then ask for a pull request on the list - preferably including at least a general overview and a shortlog of the changes. A full log with diffs is also fine. Alternatively, git email direct to the list is also perfectly acceptable. Attaching patches to specific tickets is fine too, but Trac is a bit weird when adding attachments as it doesn't seem to send out email notifications to the list for attachments, so probably best to avoid this route (or add a comment to the bug after attaching to ensure someone notices :p) If the changes are relatively trivial/uncontroversial then I can merge them in. If they are more fundamental then I usually defer to Lennart to do the merging/reviewing etc. seeing as he is the PA guru. Feel free to hang out in IRC at #pulseaudio. I'm coling there. I look forward to your contributions! Cheers Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mandriva Linux Contributor [http://www.mandriva.com/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss at mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
