Hi, As we had some issues running make distcheck with the latest release can someone give some feedback on the following three patches (against stable queue for now but will also go into master). The first patch basically just introduces some dummy Makefile.am's to ensure that the necessary directories are created in the build directory (for out of tree builds). This prevents the cc warnings about not being able to find an directory (a minor annoyance) but also allows the build to complete and do the necessary i18n stuff on the .desktop files which normally fail due to src/daemon not being a directory in the build tree (this is a bug in intl-tool as noted in the commit message). The second patch fixes a problem when running make distcheck related to the udev rules. It insists on using the system folder and does not seem to honour DESTDIR. I guess a distcheck doesn't actually use a DESTDIR but a custom prefix and thus it fails. I'm not sure this is the best approach to fixing this but it seems to work for me. Feel free to test without this patch to see if it "just works" for you without it. And thirdly this patch ensures the .version file is included in the tarball as stated in the docs of git-version-gen. Without this make distcheck fails as the source tree is read-only and thus the .version file cannot be created. By including it in the tarball, it does not get overwritten and the build works fine. Comments welcome as I'm no autofoo expert and am just blundering around until things generally work. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-build-sys-Replace-dummy-Makefiles-with-proper-Makefi.patch Type: text/x-patch Size: 28681 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20101204/59cd4923/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-build-sys-Fix-make-distcheck-failure-due-to-udev-rul.patch Type: text/x-patch Size: 747 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20101204/59cd4923/attachment-0001.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-build-sys-Include-the-.version-file-in-the-distribut.patch Type: text/x-patch Size: 1476 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20101204/59cd4923/attachment-0002.bin>
