Hiya Seems like a good patch at first glance. One minor question that I really don't know the answer to right now, but firgured it's worth asking. This approach seems totally separate from the device reservation protocol that works between Jack and PA to do graceful handover. Is there any chance of races here between the two different IPCs? I don't think so (i'd expect Jack to ensure it gets the device first before it reports that it isStarted()). I suspect that this is actually needed as if we try to load the jack-sink's immediately when we hand over the device control to jack, then jack is likely not ready yet (I think Lennart mentioned this in the past, and thus makes me thing that speaking to jack directly (as you do) is the only way to make this work correctly) 'Twas brillig, and David Henningsson at 03/12/10 08:29 did gyre and gimble: > * A question is about the default; patch 2 here adds it to default.pa. > Should "connect" default to true or false in such a scenario? I think it > depends on whether we're aiming for just showing the user the > possibility (connect=false), or if we're aiming for a just-works > experience (connect=true), which might upset a few people who don't want > it to work that way...I've gone with connect=true as the default to > mimic the behaviour of module-jack-sink and module-jack-source. I think it's probably OK to go into default.pa, but it could also be an option in paprefs too..... e.g. a ticky box for: "[ ] Automatically redirect audio through Jack if it is started" or similar. WDYT is best? Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
