On Tue, 30 Nov 2010, Colin Guthrie wrote: > Any comments on this one Jyri? > > It seems add code to sink_write_volume_cb() to mirror the normal method > sink_set_volume_cb() so looks OK to me but not followed the path through > to see if this is supposed to be factored in already in some other way... > > Your thoughts would be appreciated. > Yes, The base volume stuff appeared some time between the first version of sync volume and my upstream rebase. AFAIK, the fix is correct. However, there is still the double use of string bug (originally coming from me, but it looks quite different now). The bug is not serious, the print just is not very informative. Am currently working on a problem caused by safety-margin not taken into account when rewinding. When I get this fixed I'll add a fix for double use bug too. Cheers, Jyri > Col > > > 'Twas brillig, and Juho H?m?l?inen at 25/11/10 13:15 did gyre and gimble: >> Currently if sink base volume differs from 0dB and sync-volume is used, >> wrong volume values are written to hw. This patch fixes that. >> >> >> Signed-off-by: Juho H?m?l?inen <ext-juho.hamalainen at nokia.com> >> --- >> src/modules/alsa/alsa-sink.c | 10 ++++++++-- >> 1 files changed, 8 insertions(+), 2 deletions(-) >> >> >> >> _______________________________________________ >> pulseaudio-discuss mailing list >> pulseaudio-discuss at mail.0pointer.de >> https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss > > > -- > > Colin Guthrie > gmane(at)colin.guthr.ie > http://colin.guthr.ie/ > > Day Job: > Tribalogic Limited [http://www.tribalogic.net/] > Open Source: > Mageia Contributor [http://www.mageia.org/] > PulseAudio Hacker [http://www.pulseaudio.org/] > Trac Hacker [http://trac.edgewall.org/] > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at mail.0pointer.de > https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
