On Fri, Mar 27, 2009 at 12:16 AM, Lennart Poettering <lennart at poettering.net> wrote: > On Thu, 26.03.09 20:43, Maarten Bosmans (mkbosmans at gmail.com) wrote: > >> It looks like the parameter master for module-combine doesn't work, it >> gives an error upon loading the module. Only listing all the sinks >> under slaves works though. I wanted to update the documentation on >> http://pulseaudio.org/wiki/Modules#module-combine, but am not sure >> about the details. Is it just that specifying the master isn't >> necessary anymore? > > Yes, that is the case. All "sub"-sinks are now treated the same. Thanks for the info, I updated the wiki to reflect this. >> Without choosing a master sink the sample rate/type isn't correctly >> chosen. I found this out when I combined three 48000 Hz sinks and saw >> that the combined sink was somehow chosen to be the default 44100. >> With only a listing of sinks under slaves it is not always obvious >> which rate must be choosen, bute surely with three identical sinks the >> sample rate/type of the combined sink should be the same. > > Currently the sampling rate of the combined sink is simply taken from > the server's default sampling rate or from the settings passed as > module arguments. But yes, for statically defined combined sinks > (i.e. those with a fixed list of "sub"-sinks) it might make sense to > deduce the sampling parameters from the "sub"-sinks at take the > "highest" of the settings of them for the combined sink. > > Patches always welcome. Otherwise file a feature request bug and I > will look into it eventually. I did both: http://pulseaudio.org/ticket/521 Would you care to comment? > > Lennart > > -- > Lennart Poettering ? ? ? ? ? ? ? ? ? ? ? ?Red Hat, Inc. > lennart [at] poettering [dot] net ? ? ? ? ICQ# 11060553 > http://0pointer.net/lennart/ ? ? ? ? ? GnuPG 0x1A015CC4 > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at mail.0pointer.de > https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
