On Tue Mar 11, 2025 at 2:21 PM -05, Armin Wolf wrote: > Am 09.03.25 um 06:13 schrieb Kurt Borja: > >> Add a non-deprecated version of wmi_get_acpi_device_uid(). > > Hi, > > i can understand you motivation behind this patch, but this is IMHO the wrong approach. > Nothing guarantees us that a given ACPI _UID value will reliably signal the presence of > WMI methods now or in the future. Because of this i am against this patch. Yes, in the end it is a leap of faith. I think that it's not very risky as AFAIK AWCC didn't even exist when devices used the legacy RGB interface. Also as Mario mentioned, only a handful of devices supported the legacy interface, compared to the large amount of systems with the AWCC one. But of course, there is always a possibility of regressions for some unknown edge case. > > The correct way would be to use the BMOF data to check for missing WMI methods. I did > some work on that which i will announce soon. Anyways, this is very cool and indeed the correct approach. Hopefully I'll be able to help a bit, as I spent some time studying Pali's decoder. -- ~ Kurt
