On 3/8/25 12:23, Kurt Borja wrote:
Hi all,
This set mainly adds hwmon and manual fan control support (patches 7-8)
to the alienware-wmi driver, after some improvements.
I have a question for anyone that may know how to solve it. In version 2
of these series the kernel test robot found a build error
https://lore.kernel.org/platform-driver-x86/202503051819.bQ9P70Og-lkp@xxxxxxxxx/
I think this happened because
CONFIG_ALIENWARE_WMI=y
while
CONFIG_ACPI_PLATFORM_PROFILE=m
CONFIG_HWMON=m
How should I Kconfig to avoid this?
If hwmon is considered to be mandatory, you'll need
depends on HWMON=y
Alternative would be to use
depends on HWMON=y || HWMON=n
and use IS_ENABLED(). Something like
if (IS_ENABLED(CONFIG_HWMON) && awcc->hwmon) {
ret = awcc_hwmon_init(wdev);
if (ret)
return ret;
}
Using IS_REACHABLE() would be another option.
The CONFIG_ACPI_PLATFORM_PROFILE problem is probably similar. You can not
have CONFIG_ALIENWARE_WMI as boolean depending on code which can be built
as module.
Guenter
