On Thu, Mar 6, 2025 at 10:39 AM Choong Yong Liang <yong.liang.choong@xxxxxxxxxxxxxxx> wrote: > On 6/3/2025 3:15 pm, Andy Shevchenko wrote: > > Thu, Feb 27, 2025 at 08:15:21PM +0800, Choong Yong Liang kirjoitti: ... > >> config DWMAC_INTEL > >> default X86 > >> depends on X86 && STMMAC_ETH && PCI > >> depends on COMMON_CLK > >> + depends on ACPI > > Stray and unexplained change. Please, fix it. We don't need the dependencies > > which are not realised in the compile time. > > The dependency on ACPI is necessary because the intel_pmc_ipc.h header > relies on ACPI functionality to interact with the Intel PMC. So, that header has to be fixed as ACPI here is really unneeded dependency for the cases when somebody (for whatever reasons) want to build a kernel without ACPI support but with the driver enabled for let's say PCI device. -- With Best Regards, Andy Shevchenko
