Am 03.03.25 um 14:24 schrieb Joshua Grisham:
Fixes logic error when block_recording is not supported but the fw attr was
being added anyway (reported by GitHub user bbregeault).
Tested myself on a Samsung Galaxy Book2 Pro (has block_recording) and by
bbregeault on a Galaxy Book2 Business (does not have block_recording).
For the future you can use Tested-by tags to indicate who tested this patch.
For now:
Reviewed-by: Armin Wolf <W_Armin@xxxxxx>
Fixes: 56f529ce4370 ("platform/x86: samsung-galaxybook: Add samsung-galaxybook driver")
Signed-off-by: Joshua Grisham <josh@xxxxxxxxxxxxxxxxx>
---
v1->v2:
- Add Fixes tag with prior commit (thanks Ilpo for catching!)
---
drivers/platform/x86/samsung-galaxybook.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c
index de1ed2dc6..5878a3519 100644
--- a/drivers/platform/x86/samsung-galaxybook.c
+++ b/drivers/platform/x86/samsung-galaxybook.c
@@ -1100,11 +1100,13 @@ static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook)
}
err = galaxybook_block_recording_init(galaxybook);
- if (!err)
- galaxybook->has_block_recording = true;
- else if (err != GB_NOT_SUPPORTED)
+ if (err == GB_NOT_SUPPORTED)
+ return 0;
+ else if (err)
return err;
+ galaxybook->has_block_recording = true;
+
return galaxybook_fw_attr_init(galaxybook,
GB_ATTR_BLOCK_RECORDING,
&block_recording_acpi_get,
