[AMD Official Use Only - AMD Internal Distribution Only] Hi Krzysztof, I should have called this patch v2 (instead of v1), sorry for the confusion caused, will take care of it in my next submissions. Here is the changelog for v2: - Adding ov05c acpi hw id check to ensure platform/x86 amd-isp driver runs on the intended AMD platform. - Updated the copyright header and license used. - Addressed few other comments from Mario related to module dependencies and naming. I'm currently reviewing the feedback from Hans on v1 and will follow up to any feedback as a v3 with changelog appended under the cutlist. Thanks for your review and guidance, Pratap -----Original Message----- From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Sent: Monday, March 3, 2025 2:13 AM To: Nirujogi, Pratap <Pratap.Nirujogi@xxxxxxx>; Limonciello, Mario <Mario.Limonciello@xxxxxxx>; hdegoede@xxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx Cc: platform-driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Chan, Benjamin (Koon Pan) <Benjamin.Chan@xxxxxxx> Subject: Re: [PATCH v1] platform/x86: amd: Add ISP platform info Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 03/03/2025 06:00, Pratap Nirujogi wrote: > Add ov05c i2c boardinfo and GPIO pin info for AMD ISP platform. > > Details of the resources added: > > - Added i2c bus number for AMD ISP platform is 99. > - Added GPIO 85 to allow ISP driver to enable and disable ISP access. > - Added GPIO 0 to allow sensor driver to enable and disable sensor module. > > Signed-off-by: Pratap Nirujogi <pratap.nirujogi@xxxxxxx> Didn't you already sent v1? And receive comments? > --- Where is the changelog? What happened in this patch comparing to v1? Best regards, Krzysztof