On Sun, 2 Mar 2025, Joshua Grisham wrote: > Fixes logic error when block_recording is not supported but the fw attr is > being added anyway (reported by GitHub user bbregeault). > > Signed-off-by: Joshua Grisham <josh@xxxxxxxxxxxxxxxxx> Please add a Fixes tag. -- i. > --- > drivers/platform/x86/samsung-galaxybook.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c > index de1ed2dc6..5878a3519 100644 > --- a/drivers/platform/x86/samsung-galaxybook.c > +++ b/drivers/platform/x86/samsung-galaxybook.c > @@ -1100,11 +1100,13 @@ static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook) > } > > err = galaxybook_block_recording_init(galaxybook); > - if (!err) > - galaxybook->has_block_recording = true; > - else if (err != GB_NOT_SUPPORTED) > + if (err == GB_NOT_SUPPORTED) > + return 0; > + else if (err) > return err; > > + galaxybook->has_block_recording = true; > + > return galaxybook_fw_attr_init(galaxybook, > GB_ATTR_BLOCK_RECORDING, > &block_recording_acpi_get, >
