On 2/25/2025 06:25, Antheas Kapenekakis wrote:
Hi Luke, please add appropriate attribution. Closes: https://lore.kernel.org/all/20250224195059.10185-1-lkml@xxxxxxxxxxx/ Reported-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
Good call on adding these tags.
For me, this patch series plus the multi-platform profile one constitute a double ABI break. Not only does the legacy sysfs for platform profile regress when there is a second profile handler for a device, but all hardcoded scripts for Asus devices will have to be updated.
The documentation says to look at platform_profile_choices. To determine what is supported. FWIW this is exactly what power-profiles-daemon does.
While I would personally like to avoid this, I am ok with it, given appropriate attribution, since I did go through the effort of reporting it and providing a mitigation. @Mario: you added Reviewed-by to a patch without proper attribution. Let's not rehash our discussion from few days ago. Please try to do better when it comes to attributions in the future. Antheas
It's an oversight, no malice intended. b4 (which most maintainers use) scans the whole thread for tags. Adding them inline as a response is totally fine.
If Luke needs to spin a v2 for some reason before this is committed then he can add them as well to the v2.
