> If these "scripts" use `platform_profile_choices` to get their > selections and verify they are available then there should be zero > breakage. If they don't then they should be updated to be correct. Yeah, if any Asus users wrote scripts for their laptops to e.g., "echo quiet | sudo tee /sys/firmware/acpi/platform_profile" or used TLP let them spend a few days finding out why kernel 6.14 does not work. They should have written a 300 line bash script instead. > In any case I am in the process of finalising an update to use the new > platform_profile API including "custom". Please don't begin trying to > break things just to be "first". My work has been ongoing for this drivers/acpi/platform_profile.c | 57 +++++++++++++++++++++++++----- drivers/platform/x86/amd/pmf/spc.c | 3 ++ drivers/platform/x86/amd/pmf/sps.c | 8 +++++ include/linux/platform_profile.h | 7 ++++ I do not see the name Asus here. This is a compatibility patch. You should try it before commenting on it further. Looking at my ACPI database, there are at least a few Ayaneos, GPDs, and Legion laptops that have the ACPI bindings for pmf, this is not an Asus issue. By the way, I have merged your patch series on Bazzite (well... a cleaned up version that does not happen to crash your own software...) and it happens to work fine with this patch (I know you said platform profiles are not in yet). I still use the asus-wmi APIs personally. sudo fwupdmgr get-bios-setting Authenticating… [ - ] ppt_pl3_fppt: Setting type: Integer Current Value: 80 Description: Set the CPU slow package limit Read Only: False Minimum value: 5 ... > in my spare time for months. Let me comment on this a bit further. Hobbies are good to have and it is nice you found one you like. However, a lot of people are spending a lot of money on their Asus laptops and are actually starting to depend on Linux. If they cannot depend on you or your hobby for support, you should at least make sure to not interfere with parallel efforts for that support, if not try to be synergistic. I did not make this patch to one up you or rush it. This issue is a blocker for deploying our 6.13 kernel. Since this kernel needs to work for the Z13 and pmf quirks are dead ends now (I also got annoyed by asus users complaining about their fan curves being wrong because pmf blew up), I pulled in Mario's platform profile series early, only to find this issue. Botching the asus-wmi platform handler did not meet my standards, so I had to make this series. Also, since I could not pull in Kurk's series, and his changes were extensive, I had to make this series twice, and test it twice. Good news is this series works and the kernel is on its way to be deployed in a few days. Flatpak fix came in clutch today too with 6.13.4. Antheas
