Dear Hans de Goede,
Thank you for the reply and suggestions. I have obtained kernel sources
using distro's packet manager (apt-get source linux-source) for the
running kernel in order to build single module. Building the whole
kernel on a super low-power device is not an option. The distro's source
is not a git repository. Is it possible to provide patch without git? Or
the only option is to git clone linux source, replace hid.c and git?
Kind regards,
Dmitry Panchenko
On 20.02.25 15:47, Hans de Goede wrote:
Hi Dmitry,
On 19-Feb-25 11:08 PM, Dmitry Panchenko | d-Systems wrote:
Hello,
Volume buttons on Microsoft Surface Go 4 tablet didn't send any events. Adding Surface Go 4 to button_array_table fix this.
The patch is attached.
Signed-off-by: Dmitry Panchenko <dmitry@xxxxxxxxxxxx>
Thank you for your patch. Unfortunately this is not in the correct format
for submitting patches. It is close though, good job for a first try.
To turn this into a proper patch, make the changes from your attached
patch to a git clone of a recent kernel tree (e.g, Linus Torvald's tree)
and then after making the changes do:
git commit -as
and for the commit message use:
"""
platform/x86: intel-hid: fix volume buttons on Microsoft Surface Go 4 tablet
Volume buttons on Microsoft Surface Go 4 tablet didn't send any events.
Add Surface Go 4 DMI match to button_array_table to fix this.
Signed-off-by: Dmitry Panchenko <dmitry@xxxxxxxxxxxx>
"""
and then do:
git format-patch HEAD~
to get a 0001-xxxxxx.patch file, followed by:
git send-email 0001-xxxxxx.patch
to send an email.
Note this also requires that you first setup a ~/.gitconfig for your
name + email, as well as send-email config, e.g. I have:
"""
[user]
name = Hans de Goede
email = hdegoede@xxxxxxxxxx
[sendemail]
from = Hans de Goede <hdegoede@xxxxxxxxxx>
smtpserver = smtp.corp.redhat.com
"""
Or alternatively I can send a v2 patch for your putting things in
the right format.
Regards,
Hans
