Re: [PATCH 1/4] platform/x86/amd/pmc: Notify user when platform does not support s0ix transition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/17/2025 02:17, Shyam Sundar S K wrote:
Some of the AMD platforms do not support modern standby, so when such
CPU ID is detected, a warning message will be displayed to the user.

Co-developed-by: Sanket Goswami <Sanket.Goswami@xxxxxxx>
Signed-off-by: Sanket Goswami <Sanket.Goswami@xxxxxxx>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>

Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>

This patch specifically I think should also be

Cc: stable@xxxxxxxxxxxxxxx

---
  drivers/platform/x86/amd/pmc/pmc.c | 3 ++-
  drivers/platform/x86/amd/pmc/pmc.h | 1 +
  2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/amd/pmc/pmc.c b/drivers/platform/x86/amd/pmc/pmc.c
index e6124498b195..c7c7afb8a431 100644
--- a/drivers/platform/x86/amd/pmc/pmc.c
+++ b/drivers/platform/x86/amd/pmc/pmc.c
@@ -808,6 +808,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_PCO) },
  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_RV) },
  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_SP) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_SHP) },
  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M20H_ROOT) },
  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M60H_ROOT) },
  	{ }
@@ -832,7 +833,7 @@ static int amd_pmc_probe(struct platform_device *pdev)
dev->cpu_id = rdev->device; - if (dev->cpu_id == AMD_CPU_ID_SP) {
+	if (dev->cpu_id == AMD_CPU_ID_SP || dev->cpu_id == AMD_CPU_ID_SHP) {
  		dev_warn_once(dev->dev, "S0i3 is not supported on this hardware\n");
  		err = -ENODEV;
  		goto err_pci_dev_put;
diff --git a/drivers/platform/x86/amd/pmc/pmc.h b/drivers/platform/x86/amd/pmc/pmc.h
index f43f0253b0f5..8f39988ce7a3 100644
--- a/drivers/platform/x86/amd/pmc/pmc.h
+++ b/drivers/platform/x86/amd/pmc/pmc.h
@@ -79,6 +79,7 @@ void amd_mp2_stb_deinit(struct amd_pmc_dev *dev);
  #define AMD_CPU_ID_CB			0x14D8
  #define AMD_CPU_ID_PS			0x14E8
  #define AMD_CPU_ID_SP			0x14A4
+#define AMD_CPU_ID_SHP			0x153A
  #define PCI_DEVICE_ID_AMD_1AH_M20H_ROOT 0x1507
  #define PCI_DEVICE_ID_AMD_1AH_M60H_ROOT 0x1122
  #define PCI_DEVICE_ID_AMD_MP2_STB	0x172c





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux