Hi Andy, Thank you for your review! On Tue Feb 11, 2025 at 11:41 AM -05, Andy Shevchenko wrote: > On Fri, Feb 07, 2025 at 10:46:05AM -0500, Kurt Borja wrote: >> Rename alienware-wmi to support upcoming split. > > (the change that is caught by my eye and induced this review session) > > ... > >> obj-$(CONFIG_ALIENWARE_WMI) += alienware-wmi.o >> +alienware-wmi-objs := alienware-wmi-base.o > > objs is incorrect! Please use correct y instead. I want to understand what is exactly wrong here. This `objs` pattern is used a lot in this file, so I just copied it. For example [1]. Is it wrong to do it here for a single file? Is it wrong to do it at all? My goal is to split the file, but link it all together in a single module. [1] https://elixir.bootlin.com/linux/v6.14-rc2/source/drivers/platform/x86/dell/Makefile#L14 -- ~ Kurt > >> obj-$(CONFIG_DCDBAS) += dcdbas.o >> obj-$(CONFIG_DELL_LAPTOP) += dell-laptop.o >> obj-$(CONFIG_DELL_RBTN) += dell-rbtn.o
