On Fri, Feb 07, 2025 at 10:46:06AM -0500, Kurt Borja wrote: > Add a header file for alienware-wmi with shared resources to support the > upcoming file split. ... > static const struct attribute_group *alienfx_groups[] = { > &zone_attribute_group, > - &hdmi_attribute_group, > - &lifier_attribute_group, > - &deepsleep_attribute_group, > + WMAX_DEV_GROUPS > NULL I don't like this change as it makes code harder to understand (at one glance you can't answer the question "what are the groups that being listed here?". > }; ... > +#include <linux/leds.h> > +#include <linux/platform_device.h> > +#include <linux/wmi.h> This should follow IWYU principle, now it looks like random stuff which this header does *not* use. -- With Best Regards, Andy Shevchenko