On Tue, 11 Feb 2025, Vadim Pasternak wrote:
> Add new field 'capability_mask' to structs 'mlxreg_core_data' and
> 'mlxreg_core_item'.
>
> The ‘capabilty_mask’ is associated with the relevant capability
capability_mask
> registers, indicating which attributes should be handled and which
> ignored. Register contains bitmask of attributes or number of
> attributtes, which should be handled. While 'capability mask' is
attributes
The sentence starting with "While" feels incomplete.
> superset.
>
> Reviewed-by: Felix Radensky <fradensky@xxxxxxxxxx>
> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
> ---
> v5->v6
> Revised after comments pointed out by Ilpo:
> - Drop 'capability_bit' from structure 'mlxreg_core_data', since it is
> not used.
> ---
> include/linux/platform_data/mlxreg.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/platform_data/mlxreg.h b/include/linux/platform_data/mlxreg.h
> index 0b9f81a6f753..b2a3377a28e5 100644
> --- a/include/linux/platform_data/mlxreg.h
> +++ b/include/linux/platform_data/mlxreg.h
> @@ -118,6 +118,7 @@ struct mlxreg_hotplug_device {
> * @mask: attribute access mask;
> * @bit: attribute effective bit;
> * @capability: attribute capability register;
> + * @capability_mask: superset mask for capability register;
> * @reg_prsnt: attribute presence register;
> * @reg_sync: attribute synch register;
> * @reg_pwr: attribute power register;
> @@ -138,6 +139,7 @@ struct mlxreg_core_data {
> u32 mask;
> u32 bit;
> u32 capability;
> + u32 capability_mask;
> u32 reg_prsnt;
> u32 reg_sync;
> u32 reg_pwr;
> @@ -162,6 +164,7 @@ struct mlxreg_core_data {
> * @reg: group interrupt status register;
> * @mask: group interrupt mask;
> * @capability: group capability register;
> + * @capability_mask: superset mask for capability register;
> * @cache: last status value for elements fro the same group;
> * @count: number of available elements in the group;
> * @ind: element's index inside the group;
> @@ -175,6 +178,7 @@ struct mlxreg_core_item {
> u32 reg;
> u32 mask;
> u32 capability;
> + u32 capability_mask;
> u32 cache;
> u8 count;
> u8 ind;
>
--
i.
