On Tue, Feb 04, 2025 at 02:10:17PM +0800, Choong Yong Liang wrote: > + int (*config_serdes)(struct net_device *ndev, > + void *priv, > + phy_interface_t interface); Since you call this from phylink's mac_finish() method, I would much rather the call down into platform code was also called the same so we don't end up with a proliferation of methods called from that function. As such, please also arrange for it to pass the AN mode as well. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!