On Fri, 24 Jan 2025, Vadim Pasternak wrote:
> Replace in 'for' loop - /i >= 0 ; i--/i >= 0 ;i--/.
> Replace in 'while' loop - /(--i >= 0)/(--i)/.
>
> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
> ---
> drivers/platform/mellanox/mlx-platform.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/mellanox/mlx-platform.c b/drivers/platform/mellanox/mlx-platform.c
> index 4ed0f05449d5..ee72a53a8b06 100644
> --- a/drivers/platform/mellanox/mlx-platform.c
> +++ b/drivers/platform/mellanox/mlx-platform.c
> @@ -7850,7 +7850,7 @@ static int mlxplat_platdevs_init(struct mlxplat_priv *priv)
> while (--i)
> platform_device_unregister(priv->pdev_dpu[i]);
> fail_platform_wd_register:
> - while (--i >= 0)
> + while (--i)
> platform_device_unregister(priv->pdev_wd[i]);
These are not equal, 0th element will not get unregistered. You need to
use postdecrement so that value 1 becomes 0 while indexing it:
while (i--)
There's one similar problem also in the code added in the previous patch.
> fail_platform_fan_register:
> if (mlxplat_regs_io)
> @@ -7871,7 +7871,7 @@ static void mlxplat_platdevs_exit(struct mlxplat_priv *priv)
>
> for (i = MLXPLAT_CPLD_DPU_MAX_DEVS - 1; i >= 0; i--)
> platform_device_unregister(priv->pdev_dpu[i]);
> - for (i = MLXPLAT_CPLD_WD_MAX_DEVS - 1; i >= 0 ; i--)
> + for (i = MLXPLAT_CPLD_WD_MAX_DEVS - 1; i >= 0; i--)
> platform_device_unregister(priv->pdev_wd[i]);
> if (priv->pdev_fan)
> platform_device_unregister(priv->pdev_fan);
> @@ -7916,7 +7916,7 @@ static int mlxplat_i2c_mux_topology_init(struct mlxplat_priv *priv)
> return mlxplat_i2c_mux_complition_notify(priv, NULL, NULL);
>
> fail_platform_mux_register:
> - while (--i >= 0)
> + while (--i)
Ditto.
> platform_device_unregister(priv->pdev_mux[i]);
> return err;
> }
> @@ -7925,7 +7925,7 @@ static void mlxplat_i2c_mux_topology_exit(struct mlxplat_priv *priv)
> {
> int i;
>
> - for (i = mlxplat_mux_num - 1; i >= 0 ; i--) {
> + for (i = mlxplat_mux_num - 1; i >= 0; i--) {
> if (priv->pdev_mux[i])
> platform_device_unregister(priv->pdev_mux[i]);
> }
>
--
i.
