> and unusual. At bare minimum it needs a comment. I.o.w. the Q here is "Why is > the type_from check superior to the device?" > > > + *type = int3472_gpio_map[i].type_to; > > + *gpio_flags = int3472_gpio_map[i].polarity_low ? > > + GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH; > > + *func = int3472_gpio_map[i].func; > > + return; > > + } > -- Regards, Sakari Ailus