Hi Sakari, On 23-Jan-25 10:14 AM, Sakari Ailus wrote: > Hi Andy, > > On Wed, Jan 22, 2025 at 06:51:06PM +0200, Andy Shevchenko wrote: >> On Wed, Jan 22, 2025 at 12:43:44PM +0200, Sakari Ailus wrote: .... >>> - int3472_get_func_and_polarity(type, &func, &polarity); >>> + int3472_get_func_and_polarity(int3472->sensor, &type, &func, >>> + &polarity); >> >> AFAIK, we don't have hard attachment to the 80-[character limit rule, please >> use more room on the previous line. > > There's no reason for the line to be above 80 characters. I known that under drivers/media the consensus is to try and stick to the 80 chars length limit. But under drivers/platform/x86 we have embraced the new 100 chars limit and we prefer to use the full 100 chars over unnecessarily splitting statements over 2 lines. We are of the opinion that a single slightly longer line is easier to read then a statement split over 2 lines, so please change this to: int3472_get_func_and_polarity(int3472->sensor, &type, &func, &polarity); Regards, Hans
